Repository navigation
Add support for new MSAPP format with ControlPropertyState and Category properties - #762
Merged
Merged
Conversation
…s to schema classes
…ic properties. Add app with categoty and ControlPropertyState to test (RoundripTests)
Marcel Ferreira (marcelbf)
requested review from
Copilot and
Joe Mayo (MSFT) (joem-msft)
October 11, 2025 05:12
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new MSAPP format that includes ControlPropertyState and Category properties used by PowerApps Studio for responsive layout metadata and rule categorization. The changes ensure proper serialization/deserialization and maintain backward compatibility.
- Added
Categoryfield toRuleEntryandPropertyStateclasses for rule categorization - Added
ControlPropertyStatefield toDynamicPropertyJsonandDynamicPropertyStateclasses for responsive layout metadata - Enhanced logic in
IRStateHelpersto handle the new properties during pack/unpack operations
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/PAModel/Schemas/adhoc/Control.cs | Added Category and ControlPropertyState schema fields |
| src/PAModel/IR/IRStateHelpers.cs | Enhanced property handling logic and serialization for new fields |
| src/PAModel/EditorState/PropertyState.cs | Added Category field to PropertyState class |
| src/PAModel/EditorState/DynamicPropertyState.cs | Added ControlPropertyState field to DynamicPropertyState class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
McCall Saltzman (lesaltzm)
approved these changes
Oct 13, 2025
Crash Collison (tehcrashxor)
approved these changes
Oct 13, 2025
Marcel Ferreira (marcelbf)
enabled auto-merge (squash)
October 13, 2025 16:38
Crash Collison (tehcrashxor)
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#759 #756 #755 #754
Problem
The PASopa tool was failing to pack new MSAPP format files that contain ControlPropertyState properties in dynamic properties. These properties are used by PowerApps Studio for responsive layout metadata and rule categorization. The tool was encountering JSON deserialization errors because the schema didn't support these new properties.
Solution
Enhanced the schema definitions to support the new MSAPP format properties and fixed serialization issues to ensure proper roundtrip compatibility. The solution preserves both the logic and metadata (ControlPropertyState, Category) for dynamic properties while maintaining backward compatibility.
Changes
Validation
Add a new MSAPP file with these properties, to be executed with RoundtripTests.
All RoundtripTests pass (36/36)
All tests running
Successfully tested pack/unpack operations on new MSAPP format files with 0 errors
Verified backward compatibility with existing MSAPP files without the new properties
Confirmed that the solution handles both scenarios: properties with rules + metadata, and metadata-only properties